Skip to content

Integrate PR #66: Add comprehensive package management features with web interface #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

Integrate PR #66: Add comprehensive package management features with web interface #89

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
cbe1e73
Initial plan
Copilot Dec 9, 2025
a4cac82
Add new feature modules from PR #66
Copilot Dec 9, 2025
be28d0c
Integrate new CLI commands while preserving existing functionality
Copilot Dec 9, 2025
43ed81d
Address code review feedback - improve security, logging, and documen…
Copilot Dec 9, 2025
642faf6
Fix Flask debug mode security issue - disable debug in production
Copilot Dec 9, 2025
52e7179
Fix command recognition - add new commands to known commands list
Copilot Dec 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
483 changes: 481 additions & 2 deletions archpkg/cli.py
View file
Open in desktop

Large diffs are not rendered by default.

135 changes: 135 additions & 0 deletions archpkg/config_manager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,135 @@
#!/usr/bin/env python3
"""
Configuration management for archpkg-helper
"""

import json
import os
from pathlib import Path
from typing import Dict, Any, Optional
from dataclasses import dataclass, asdict
from archpkg.logging_config import get_logger

logger = get_logger(__name__)

@dataclass
class UserConfig:
"""User configuration settings"""
auto_update_enabled: bool = False
auto_update_mode: str = "manual" # "automatic" or "manual"
update_check_interval_hours: int = 24
background_download_enabled: bool = True
notification_enabled: bool = True

class ConfigManager:
"""Manages user configuration with atomic file operations"""

def __init__(self):
self.config_dir = Path.home() / ".archpkg"
self.config_file = self.config_dir / "config.json"
self._ensure_config_dir()

def _ensure_config_dir(self) -> None:
"""Ensure configuration directory exists"""
self.config_dir.mkdir(parents=True, exist_ok=True)

def _atomic_write(self, data: Dict[str, Any]) -> None:
"""Atomically write configuration to file"""
temp_file = self.config_file.with_suffix('.tmp')

try:
# Write to temporary file first
with open(temp_file, 'w', encoding='utf-8') as f:
json.dump(data, f, indent=2, ensure_ascii=False)

# Atomic move to final location
temp_file.replace(self.config_file)
logger.info(f"Configuration saved to {self.config_file}")

except Exception as e:
# Clean up temp file on error
if temp_file.exists():
temp_file.unlink()
logger.error(f"Failed to save configuration: {e}")
raise

def load_config(self) -> UserConfig:
"""Load configuration from file"""
if not self.config_file.exists():
logger.info("No configuration file found, using defaults")
return UserConfig()

try:
with open(self.config_file, 'r', encoding='utf-8') as f:
data = json.load(f)

# Create config object from loaded data
config = UserConfig()
for key, value in data.items():
if hasattr(config, key):
setattr(config, key, value)

logger.info("Configuration loaded successfully")
return config

except Exception as e:
logger.warning(f"Failed to load configuration, using defaults: {e}")
return UserConfig()

def save_config(self, config: UserConfig) -> None:
"""Save configuration to file atomically"""
data = asdict(config)
self._atomic_write(data)

def get_config_value(self, key: str) -> Any:
"""Get a specific configuration value"""
config = self.load_config()
return getattr(config, key, None)

def set_config_value(self, key: str, value: Any) -> None:
"""Set a specific configuration value"""
config = self.load_config()
if hasattr(config, key):
setattr(config, key, value)
self.save_config(config)
logger.info(f"Configuration updated: {key} = {value}")
else:
raise ValueError(f"Unknown configuration key: {key}")

def show_config(self) -> str:
"""Get formatted configuration display"""
config = self.load_config()
lines = [
f"Configuration file: {self.config_file}",
"",
"Current settings:",
f" Auto-update enabled: {config.auto_update_enabled}",
f" Auto-update mode: {config.auto_update_mode}",
f" Update check interval: {config.update_check_interval_hours} hours",
f" Background download: {config.background_download_enabled}",
f" Notifications: {config.notification_enabled}",
]
return "\n".join(lines)

# Global configuration manager instance
config_manager = ConfigManager()

def get_user_config() -> UserConfig:
"""Get current user configuration"""
return config_manager.load_config()

def save_user_config(config: UserConfig) -> None:
"""Save user configuration"""
config_manager.save_config(config)

def set_config_option(key: str, value: Any) -> None:
"""Set a configuration option"""
config_manager.set_config_value(key, value)

def get_config_option(key: str) -> Any:
"""Get a configuration option"""
return config_manager.get_config_value(key)

def show_current_config() -> str:
"""Show current configuration"""
return config_manager.show_config()
Loading