-
Notifications
You must be signed in to change notification settings - Fork 44
Open
Description
Description
Currently, the codebase has two separate functions for notifications:
scr_event_log: Adds entries to the event logscr_alert: Creates alerts/popups for the player
These functions are often called consecutively with similar parameters, as they serve complementary purposes. For example, in scr_battle_count:
scr_alert(c_blue, "reward", $"{_text_choice.alert}");
scr_event_log(c_blue, $"{_text_choice.log}");Proposed Solution
Merge these functions into a single function that handles both logging and alerts. This would:
- Reduce code duplication
- Ensure consistency between alerts and log entries
- Simplify the API for developers
Related Links
- Raised in PR discussion: feat: Imperial Loyalty #635 (comment)
Requested by: @EttyKitty
Reactions are currently unavailable