From 4086af7b76c6e1ca0981b6d7d06959cafb089e90 Mon Sep 17 00:00:00 2001 From: Chris M Date: Thu, 10 Aug 2017 17:40:25 -0700 Subject: [PATCH 1/2] Adding Comp Questions section to feedback template --- .github/PULL_REQUEST_TEMPLATE.md | 17 +++++++++-------- 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 8fd94c8..1ea4d12 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -1,11 +1,12 @@ # Random Menu -Congratulations! You're submitting your assignment. +## What We're Looking For -## Comprehension Questions - -| Question | Answer | +| Feature | Feedback | |--- |--- | -| How did you store menu components? Why? | | -| Could you have stored components using a different data structure? For example, if you used an Array could you have used a Hash? | | -| Did you find yourself repeating the same code? Why did you have to do it that way? | | -| What type of loop did you use? Why did you choose that type? | | +| Random Menu of 10 items displayed in the terminal. | Check | +| Generator pulls one random item from each array to create menu items. | Check | +| Comprehension questions answered| | +| **Baseline** | | +| Readable code with consistent indentation. | Check | +| **Extras** | | +| | | From c3d0f34dfcbec22827a079260e3581364fc1c66e Mon Sep 17 00:00:00 2001 From: Chris M Date: Thu, 10 Aug 2017 17:41:22 -0700 Subject: [PATCH 2/2] Update PULL_REQUEST_TEMPLATE.md --- .github/PULL_REQUEST_TEMPLATE.md | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 1ea4d12..f5eb568 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -3,10 +3,10 @@ | Feature | Feedback | |--- |--- | -| Random Menu of 10 items displayed in the terminal. | Check | -| Generator pulls one random item from each array to create menu items. | Check | +| Random Menu of 10 items displayed in the terminal. | | +| Generator pulls one random item from each array to create menu items. | | | Comprehension questions answered| | | **Baseline** | | -| Readable code with consistent indentation. | Check | +| Readable code with consistent indentation. | | | **Extras** | | | | |