From 54d73c2dae59537e40fe6c20376fb42a2b527c50 Mon Sep 17 00:00:00 2001
From: Arthur van de Vondervoort <arthur.vandevondervoort@vanroey.be>
Date: Fri, 12 Dec 2025 13:15:46 +0100
Subject: [PATCH] Refactor parameter handling in AddSolution to use default
 values

---
 src/RoslynTestKit/Helpers/AdhocWorkspace.cs | 49 ++++++++++++++++-----
 1 file changed, 39 insertions(+), 10 deletions(-)

diff --git a/src/RoslynTestKit/Helpers/AdhocWorkspace.cs b/src/RoslynTestKit/Helpers/AdhocWorkspace.cs
index 0b1dc82..41091e5 100644
--- a/src/RoslynTestKit/Helpers/AdhocWorkspace.cs
+++ b/src/RoslynTestKit/Helpers/AdhocWorkspace.cs
@@ -107,19 +107,48 @@ private static ProjectInfo CreateProjectInfoViaReflection(string name, string la
             var args = new object?[parameters.Length];
 
             // The first 5 parameters are always: id, version, name, assemblyName, language (required)
-            // All other parameters are optional and will use Type.Missing to get their default values
+            // All other parameters are optional - use their default values via ParameterInfo.DefaultValue
             for (int i = 0; i < parameters.Length; i++)
             {
-                var paramName = parameters[i].Name?.ToLowerInvariant();
-                args[i] = paramName switch
+                var param = parameters[i];
+                var paramName = param.Name?.ToLowerInvariant();
+
+                // Handle the 5 required parameters explicitly
+                if (paramName == "id")
+                {
+                    args[i] = ProjectId.CreateNewId();
+                }
+                else if (paramName == "version")
+                {
+                    args[i] = VersionStamp.Create();
+                }
+                else if (paramName == "name")
+                {
+                    args[i] = name;
+                }
+                else if (paramName == "assemblyname")
+                {
+                    args[i] = name;
+                }
+                else if (paramName == "language")
+                {
+                    args[i] = language;
+                }
+                // For optional parameters, use their default value or appropriate fallback
+                else if (param.HasDefaultValue)
+                {
+                    args[i] = param.DefaultValue;
+                }
+                else if (!param.ParameterType.IsValueType)
+                {
+                    // Reference types without default - use null
+                    args[i] = null;
+                }
+                else
                 {
-                    "id" => ProjectId.CreateNewId(),
-                    "version" => VersionStamp.Create(),
-                    "name" => name,
-                    "assemblyname" => name,
-                    "language" => language,
-                    _ => Type.Missing // Use default value for optional parameters
-                };
+                    // Value types without default - use default(T)
+                    args[i] = Activator.CreateInstance(param.ParameterType);
+                }
             }
 
             var result = _cachedCreateMethod.Invoke(null, args);