Skip to content

Commit 9131f6d

Browse files
committed
fix(host-sdk): remove legacy module directory fallback
1 parent fbe8e04 commit 9131f6d

File tree

2 files changed

+0
-26
lines changed

2 files changed

+0
-26
lines changed

src/Modulus.HostSdk.Runtime/ModulusHostSdkBuilder.cs

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -49,16 +49,6 @@ public ModulusHostSdkBuilder AddDefaultModuleDirectories()
4949
var userModules = Path.Combine(LocalStorage.GetUserRoot(), "Modules");
5050
_moduleDirectories.Add(new HostModuleDirectory(userModules, IsSystem: false));
5151

52-
// Backward compatibility: some hosts may have used ApplicationData directly on non-Windows before LocalStorage aligned paths.
53-
var legacyUserModules = Path.Combine(
54-
Environment.GetFolderPath(Environment.SpecialFolder.ApplicationData),
55-
"Modulus",
56-
"Modules");
57-
if (!IsSameDirectory(userModules, legacyUserModules))
58-
{
59-
_moduleDirectories.Add(new HostModuleDirectory(legacyUserModules, IsSystem: false));
60-
}
61-
6252
return this;
6353
}
6454

@@ -122,12 +112,6 @@ private static string NormalizeDirectoryPath(string path)
122112
var full = Path.GetFullPath(path);
123113
return full.TrimEnd(Path.DirectorySeparatorChar, Path.AltDirectorySeparatorChar);
124114
}
125-
126-
private static bool IsSameDirectory(string a, string b)
127-
{
128-
var comparer = OperatingSystem.IsWindows() ? StringComparer.OrdinalIgnoreCase : StringComparer.Ordinal;
129-
return comparer.Equals(NormalizeDirectoryPath(a), NormalizeDirectoryPath(b));
130-
}
131115
}
132116

133117

tests/Modulus.HostSdk.Tests/HostSdkBuilderTests.cs

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -40,19 +40,9 @@ public void AddDefaultModuleDirectories_AddsExpectedDefaultDirectories()
4040

4141
var systemDir = Path.Combine(AppContext.BaseDirectory, "Modules");
4242
var userDir = Path.Combine(LocalStorage.GetUserRoot(), "Modules");
43-
var legacyUserDir = Path.Combine(
44-
Environment.GetFolderPath(Environment.SpecialFolder.ApplicationData),
45-
"Modulus",
46-
"Modules");
4743

4844
Assert.Contains(list, d => d.IsSystem && PathEquals(d.Path, systemDir));
4945
Assert.Contains(list, d => !d.IsSystem && PathEquals(d.Path, userDir));
50-
51-
// Only included when distinct from the canonical user directory.
52-
if (!PathEquals(userDir, legacyUserDir))
53-
{
54-
Assert.Contains(list, d => !d.IsSystem && PathEquals(d.Path, legacyUserDir));
55-
}
5646
}
5747

5848
[Fact]

0 commit comments

Comments
 (0)