Merge pull request #13 from AGIBuild/cursor/analyze-plugin-architecture-optimization-gpt-5.1-codex-max-xhigh-d3ba

Analyze plugin architecture optimization

Author: Hongwei-MB

openspec/changes/update-install-host-validation/proposal.md

@@ -0,0 +1,14 @@
+# Change: Enforce host-aware manifest validation at install time
+
+## Why
+- Module installation currently skips host-specific validation; incompatible modules (unsupported host, missing UI assemblies, bad dependency ranges) slip through and fail only at runtime.
+- Installation should block or flag invalid modules before they can be enabled or loaded.
+
+## What Changes
+- Pass hostType through installer flows and enforce `supportedHosts` plus host-specific `uiAssemblies` at install time.
+- Validate dependency version ranges during install; reject or flag modules with invalid semver ranges.
+- Persist validation errors to module state and surface diagnostics to logs/UI so invalid modules are not enabled or loaded.
+
+## Impact
+- Affected specs: runtime
+- Affected code: ModuleInstallerService, manifest validation pipeline, module state handling, installer diagnostics/UX

openspec/changes/update-install-host-validation/specs/runtime/spec.md

@@ -0,0 +1,28 @@
+## ADDED Requirements
+
+### Requirement: Install-time host-aware manifest validation
+Module installation SHALL validate host compatibility, UI assemblies for the target host, and dependency version ranges before a module can be enabled or loaded.
+
+#### Scenario: Unsupported host blocks install
+- **WHEN** the installer runs with `hostType` X
+- **AND** `supportedHosts` does not include X
+- **THEN** validation fails with a diagnostic explaining the mismatch
+- **AND** the module is not marked Ready or enabled.
+
+#### Scenario: Missing host UI assemblies blocks install
+- **WHEN** the installer runs with `hostType` X
+- **AND** `uiAssemblies` is missing or empty for X
+- **THEN** validation fails with a diagnostic naming the host and missing UI assemblies
+- **AND** the module remains disabled/not Ready.
+
+#### Scenario: Invalid dependency ranges are rejected
+- **WHEN** the manifest lists dependencies with an invalid semantic version range
+- **THEN** validation fails with a diagnostic citing the offending dependency id and range
+- **AND** the module is not installed as Ready.
+
+#### Scenario: Valid manifest becomes installable
+- **WHEN** supportedHosts includes the current host
+- **AND** uiAssemblies provides entries for that host
+- **AND** all dependency ranges parse successfully
+- **THEN** installation records the module as Ready
+- **AND** the module may be enabled/loaded.

openspec/changes/update-install-host-validation/tasks.md

@@ -0,0 +1,6 @@
+## 1. Implementation
+- [ ] 1.1 Propagate hostType into installer validation paths and enforce `supportedHosts`.
+- [ ] 1.2 Require host-specific `uiAssemblies` at install time; fail or flag when missing/empty.
+- [ ] 1.3 Validate dependency version ranges during install; record diagnostics and block enable/load on invalid manifests.
+- [ ] 1.4 Persist validation outcome to module state and surface errors to logs/UI.
+- [ ] 1.5 Add tests covering install-time host/UI/dependency validation and state updates.