Some of the reports rely on name rather than ObjectSid which leads to wrong assesments (especialy in acl_anomaly control )

[ydroop]

Is your feature request related to a problem? Please describe.
Some of the reports rely on name rather than ObjectSid which leads to wrong assesments (especialy in acl_anomaly control )
In multi site entreprise, many have a structured OU divided by site , and sub OU users or computers which will have the same name in each site to meet standard structure.
In Ad Miner, some of the controls are based on python dict where the key is the name which is not accurate and can have multiple objects matching this name.

Describe the solution you'd like
I suggest to use ObjectSid as keys to avoid wrong assesments in reports,
and a tooltip with DistinguishedName (or ObjectSid) in html reports to avoid confusion

Additional context

[jmbesnard]

Thanks for reporting this which is a valid point. We will look into it but the team is currently really busy on work engagements so it won't be very soon unfortunately.
If you could propose a PR for this change, it would be much appreciated and allow for a quicker resolution.

Thanks

[ydroop]

It's quite a big impact, because it supposes to collect Object-Sid in requests, change dict keys and mappings in a few controls, and maybe also change the way report is rendered because it looks like it is used in the url to display path. so it's difficult to propose a simple MR.

[snowpeacock]

Hello and thank you for your feedback. This is indeed a structural issue with AD Miner, so I'm not sure if we'll be able to provide a fix anytime soon.

However, we are working internally on a new version that aims to reduce the number of web pages generated and uses internal neo4j IDs for that. I think this could be a partial fix and we will try to extend this concept if possible.