Skip to content

Test Duplicate Marker IDs #383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
akhuoa wants to merge 10 commits into
base: main
Choose a base branch
from
+86 −2
Open

Test Duplicate Marker IDs #383

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
67fb9ea
Test duplicate markerids
akhuoa Aug 18, 2025
c1b7aeb
Print output of duplicate markers features testing
akhuoa Aug 18, 2025
cf367a8
Format duplicate marker test output
akhuoa Aug 18, 2025
89a4fcd
Update gitignore for cypress test
akhuoa Aug 18, 2025
b5e21a9
Add feature id count in duplicate markers testing
akhuoa Aug 18, 2025
a819bdd
Merge branch 'main' into feature/test-duplicate-markerids
akhuoa Aug 18, 2025
2e564fd
Add label for duplicate marker test
akhuoa Aug 19, 2025
ec49f1b
Update label search in duplicate marker test for better performance
akhuoa Aug 19, 2025
cc2252f
Merge branch 'ABI-Software:main' into feature/test-duplicate-markerids
akhuoa Sep 9, 2025
c9642c3
Fix testing for different species and snapshot testing
akhuoa Sep 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,8 @@ cypress/results/
cypress/snapshots/
cypress/videos/
cypress/reports/
cypress/output/
cypress.env.json
test/src/
docs/.vitepress/dist
docs/.vitepress/cache
Expand Down
84 changes: 83 additions & 1 deletion cypress/component/MapContent.cy.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,6 +188,86 @@ ${publicationLink}`;
cy.get('.search-box.el-autocomplete > .el-input > .el-input__wrapper > .el-input__inner').should('exist').clear();
})

Cypress.Commands.add('markerFeatureIdsTest', () => {
const markerFeatureIds = [];
cy.get('#flatmap-select').click({force: true});
cy.get('.el-scrollbar__view.el-select-dropdown__list > li').then($lis => {
const liCount = Cypress.$($lis).filter(':visible').length;

function clickAndProcess(index) {
if (index >= liCount) return;
// if no visible list items, reopen the dropdown
if (!Cypress.$($lis).eq(index).is(':visible')) {
cy.get('#flatmap-select').click({force: true});
}

cy.get('.el-scrollbar__view.el-select-dropdown__list > li')
.eq(index)
.should('be.visible')
.click();

cy.get('.multi-container > .el-loading-parent--relative > [name="el-loading-fade"] > .el-loading-mask', {timeout: 60000})
.should('not.exist');

cy.window().then((win) => {
if (win.Cypress && win.Cypress.vue) {
const cypressVue = win.Cypress.vue;
const markers = cypressVue.settingsStore.globalSettings.displayMarkers ? cypressVue.settingsStore.markers : [];
const splitdialog = cypressVue.$refs.flow.$refs.splitdialog;

if (splitdialog) {
const activeContents = splitdialog.getActiveContents();

activeContents.forEach(content => {
if (content?.$refs['viewer']) {
const contentViewer = content.$refs['viewer'];
const flatmapImp = contentViewer.getFlatmapImp();

if (flatmapImp && markers.length) {
const flatmapId = flatmapImp.id
const fmMarkers = contentViewer.removeMarkersNotOnFlatmap(flatmapImp, markers);
const flatTerms = fmMarkers.map(t => t.terms).flat(Infinity);
const duplicateTerms = [];

flatTerms.forEach(term => {
const featureId = flatmapImp.modelFeatureIds(term);
if (featureId.length > 1) {
if (!duplicateTerms.some(item => item.term === term)) {
const annotationsArray = Array.from(flatmapImp.annotations.values());
const foundAnnotation = annotationsArray.find(annotation => annotation.models === term);
const termLabel = foundAnnotation ? foundAnnotation.label : '';
const label = termLabel.charAt(0).toUpperCase() + termLabel.slice(1);
duplicateTerms.push({
label,
term,
featureIdCount: featureId.length
});
}
}
});

if (duplicateTerms.length > 0) {
markerFeatureIds.push({
flatmapId,
duplicateTerms
});
}
}
}
});
}
}
}).then(() => {
if (markerFeatureIds.length > 0) {
cy.writeFile('cypress/output/duplicate_marker_feature_ids.json', markerFeatureIds);
}
clickAndProcess(index + 1);
});
}
clickAndProcess(0);
});
})

//Wait for the curie response before continuing
// cy.wait('@categoryResponse');

Expand Down Expand Up @@ -219,7 +299,6 @@ ${publicationLink}`;

cy.get('.multi-container > .el-loading-parent--relative > [name="el-loading-fade"] > .el-loading-mask', {timeout: 60000}).should('not.exist');


//There is some issue with capture function with Cypress causing the screenshot to be taken incorrectly,
//the following attempt to workaround it.
function is_high_resolution_screen() {
Expand Down Expand Up @@ -254,6 +333,9 @@ ${publicationLink}`;
cy.checkFlatmapProvenanceCard('Rat', mousePublicationLink);
});

// Testing duplicate marker feature IDs
cy.markerFeatureIdsTest();

//Search for non existance feature, expect not-found text
cy.get('.search-box.el-autocomplete > .el-input > .el-input__wrapper > .el-input__inner').should('exist').type("NON_EXISTANCE");
cy.get('.search-container > .map-icon > use').should('exist').click();
Expand Down
2 changes: 1 addition & 1 deletion src/mixins/DynamicMarkerMixin.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ const removeDuplicates = function (arrayOfAnything) {
JSON.parse(e)
)
}

/* eslint-disable no-alert, no-console */
export default {
computed: {
Expand Down