Skip to content

Update rollback.py #612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
8ball030 wants to merge 3 commits into
base: feat/rollback
Choose a base branch
from
Open

Update rollback.py #612

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1a612b5
Update rollback.py
8ball030 Mar 14, 2025
98fea89
chore:linters
Mar 14, 2025
fef31b6
chore:linters-within-tests
Mar 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 13 additions & 6 deletions auto_dev/utils/rollback.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,22 +1,29 @@
"""Filesystem utilities for temporary backups and rollback mechanisms."""

import os
import shutil
import signal
import tempfile
from pathlib import Path
from contextlib import chdir, contextmanager
from contextlib import contextmanager

from auto_dev.utils import signals


# https://www.youtube.com/watch?v=0GRLhpMao3I
# async-signal safe is the strongest concept of reentrancy.
# async-signal safe implies thread safe.
Copy link
Owner Author

@8ball030 8ball030 Mar 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

surprised the comments passed linters haha


# signal.SIGKILL cannot be intercepted
SIGNALS_TO_BLOCK = (signal.SIGINT, signal.SIGTERM)


@contextmanager
def chdir(new_dir):
"""Change the current working directory temporarily."""
old_dir = os.getcwd()
try:
os.chdir(new_dir)
yield
finally:
os.chdir(old_dir)
Comment on lines +16 to +24
Copy link
Collaborator

@Karrenbelt Karrenbelt Mar 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this has nothing to do with rollback. Now what?

from ... import rollback

with rollback.chdir(...):
    ....

?

Copy link
Collaborator

@Karrenbelt Karrenbelt Mar 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

besides this is not the first version of this context manager just to change dirs either. Why would we keep supporting 3.10?

Copy link
Owner Author

@8ball030 8ball030 Mar 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What exactly does the context lib version of chdir that this does not?
It can be used in the manner your suggesting?

I don't really understand why this specific function is so important?

Copy link
Owner Author

@8ball030 8ball030 Mar 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why wouldn't we support 3.10 if all it requires is not using this chdir thing?

Copy link
Collaborator

@Karrenbelt Karrenbelt Mar 14, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well there are other limitations, such as StrEnum, IntEnum etc. and who knows what else. 3.10 is from 2021, pretty old by now. End of life support still 1 year 7 month tho



def _restore_from_backup(directory: Path, backup: Path):
for item in directory.rglob("*"):
backup_item = backup / item.relative_to(directory)
Expand Down
2 changes: 1 addition & 1 deletion tests/conftest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
import os
import tempfile
from pathlib import Path
from contextlib import chdir

import pytest

Expand All @@ -13,6 +12,7 @@
DEFAULT_PUBLIC_ID,
)
from auto_dev.cli_executor import CommandExecutor
from auto_dev.utils.rollback import chdir
from auto_dev.workflow_manager import Task
from scripts.generate_command_docs import generate_docs
from auto_dev.services.package_manager.index import PackageManager
Expand Down
Loading