Skip to content

Commit 712c044

Browse files
committed
Made slight changes to make intake more consistent
1 parent 3a99c1c commit 712c044

File tree

4 files changed

+21
-4
lines changed

4 files changed

+21
-4
lines changed

src/main/java/frc/robot/RobotContainer.java

Lines changed: 12 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@
2121
import edu.wpi.first.wpilibj.Joystick;
2222
import edu.wpi.first.wpilibj2.command.Command;
2323
import edu.wpi.first.wpilibj2.command.Commands;
24+
import edu.wpi.first.wpilibj2.command.WaitCommand;
2425
import edu.wpi.first.wpilibj2.command.Command.InterruptionBehavior;
2526
import edu.wpi.first.wpilibj2.command.button.CommandXboxController;
2627
import edu.wpi.first.wpilibj2.command.button.JoystickButton;
@@ -240,8 +241,8 @@ private Command robotGoToHeightCommandCreator(ElevatorHeight height){
240241
}else{
241242
command = Commands.sequence(
242243
new WristGoToPositionCommand(wrist, WristAngleRad.L2L3),
243-
new ElevatorGoToPositionPositionCommand(elevator, height)
244-
//new WristGoToPositionCommand(wrist, getEndWristAngleForGivenElevatorHeight(height))
244+
new ElevatorGoToPositionPositionCommand(elevator, height),
245+
new WristGoToPositionCommand(wrist, getEndWristAngleForGivenElevatorHeight(height))
245246
).withInterruptBehavior(InterruptionBehavior.kCancelSelf);
246247
}
247248

@@ -253,7 +254,7 @@ private Command robotGoToHeightCommandCreator(ElevatorHeight height){
253254
private WristAngleRad getEndWristAngleForGivenElevatorHeight(ElevatorHeight height){
254255
switch(height){
255256
case HOME:
256-
return WristAngleRad.FREEHANG;
257+
return WristAngleRad.L2L3;
257258
case FUNNEL:
258259
return WristAngleRad.FUNNEL_ANGLE;
259260
case L1:
@@ -378,6 +379,14 @@ private void configureManipulatorBindings(){
378379

379380
Trigger outtakeCoralTrigger = operatorController.rightBumper();
380381
outtakeCoralTrigger.whileTrue(new OuttakeCoralCommand(manipulator));
382+
383+
Trigger takeCoralBackTrigger = operatorController.leftTrigger();
384+
takeCoralBackTrigger.whileTrue(
385+
Commands.sequence(
386+
new ManipulatorIntakeCoralCommand(manipulator),
387+
new WaitCommand(0.04),
388+
Commands.runOnce(() -> manipulator.stopOuttake(), manipulator)));
389+
381390
}
382391

383392
private void configureElevatorBindings(){

src/main/java/frc/robot/commands/ManipulatorIntakeCoralCommand.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,9 @@ public void execute() {
2929

3030
@Override
3131
public void end(boolean interrupted) {
32-
manipulator.stopOuttake();
32+
if (interrupted) {
33+
manipulator.stopOuttake();
34+
}
3335
}
3436

3537
@Override

src/main/java/frc/robot/subsystems/Manipulator/Manipulator.java

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -74,6 +74,9 @@ public void runOuttakeOut(){
7474
public void runOuttakeIn(){
7575
manipulatorIO.runOuttakeVoltage(Constants.ManipulatorConstants.intakeVoltage);
7676
}
77+
public void runOuttakeInReverse(){
78+
manipulatorIO.runOuttakeVoltage(-Constants.ManipulatorConstants.intakeVoltage);
79+
}
7780
public void stopOuttake(){
7881
manipulatorIO.stopOuttake();
7982
}

src/main/java/frc/robot/util/FunnelIntakeCommands.java

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44
import edu.wpi.first.wpilibj2.command.Command.InterruptionBehavior;
55
import edu.wpi.first.wpilibj2.command.Commands;
66
import edu.wpi.first.wpilibj2.command.ConditionalCommand;
7+
import edu.wpi.first.wpilibj2.command.WaitCommand;
78
import frc.robot.Constants.ElevatorConstants.ElevatorHeight;
89
import frc.robot.Constants.WristConstants.WristAngleRad;
910
import frc.robot.commands.ManipulatorIntakeCoralCommand;
@@ -46,6 +47,8 @@ private static Command whichFunnelIntakeCommand(Elevator elevator, Wrist wrist,
4647
new ElevatorGoToPositionPositionCommand(elevator, ElevatorHeight.FUNNEL),
4748
new WristGoToPositionCommand(wrist, WristAngleRad.FUNNEL_ANGLE),
4849
new ManipulatorIntakeCoralCommand(manipulator),
50+
new WaitCommand(0.08),
51+
Commands.runOnce(() -> manipulator.stopOuttake(), manipulator),
4952
new WristGoToPositionCommand(wrist, WristAngleRad.L2L3),
5053
new ElevatorGoToPositionPositionCommand(elevator, ElevatorHeight.HOME)
5154
);

0 commit comments

Comments
 (0)