From 1f1bec22f2b86bdee104c39a3dfb1b765942f461 Mon Sep 17 00:00:00 2001 From: Katie Dektar Date: Mon, 3 Nov 2025 19:46:00 -0800 Subject: [PATCH] Make script links clickable while still selectable Test: Manual with the issue reason in place of the script --- .../a5calls/android/a5calls/controller/RepCallActivity.java | 4 ++++ 5calls/app/src/main/res/values/styles.xml | 1 + 2 files changed, 5 insertions(+) diff --git a/5calls/app/src/main/java/org/a5calls/android/a5calls/controller/RepCallActivity.java b/5calls/app/src/main/java/org/a5calls/android/a5calls/controller/RepCallActivity.java index 46d5c6a0..a8df61bb 100644 --- a/5calls/app/src/main/java/org/a5calls/android/a5calls/controller/RepCallActivity.java +++ b/5calls/app/src/main/java/org/a5calls/android/a5calls/controller/RepCallActivity.java @@ -7,6 +7,7 @@ import android.content.Intent; import android.os.Bundle; import android.text.TextUtils; +import android.text.method.LinkMovementMethod; import android.text.util.Linkify; import android.util.DisplayMetrics; import android.util.Patterns; @@ -404,6 +405,9 @@ private void updateScriptDisplay() { getIntent().getStringExtra(KEY_LOCATION_NAME), AccountManager.Instance.getUserName(this) ); + // Explicitly set movement method because the script view has selectable text. + // See https://github.com/noties/Markwon/issues/193#issuecomment-586573860 + binding.callScript.setMovementMethod(LinkMovementMethod.getInstance()); MarkdownUtil.setUpScript(binding.callScript, script, getApplicationContext()); } diff --git a/5calls/app/src/main/res/values/styles.xml b/5calls/app/src/main/res/values/styles.xml index 19cb59c3..b71758d0 100644 --- a/5calls/app/src/main/res/values/styles.xml +++ b/5calls/app/src/main/res/values/styles.xml @@ -335,6 +335,7 @@ @dimen/padding_spinner @color/textColorDarkGrey true + true