Skip to content

harden hash/modulo checks #354

@justadreamer

Description

@justadreamer

Modify C code to prioritize (nodeOffset=0) check over (nodeOffset=hash).

Potential drawbacks:

Applying the fix would require clients to update packages.
compared to data file level fix that (if available) would be less invasive and backwards compatible.
Minor (hopefully) performance impact due to additional branching.
Full matches against actual hash 0 (not modulo) would become unavailable
(hashCode=0) is used as a sentinel value for "internal" collision resolutions within the buckets.

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions