From 8a9d0f8fb50fe13d97fa71649c5dfbf2af3e8870 Mon Sep 17 00:00:00 2001
From: Kim Shepherd <kim@shepherd.nz>
Date: Tue, 12 Aug 2025 14:00:14 +0200
Subject: [PATCH] [TLC-1172] Paginate CrisMetric db rows when updating index

---
 .../UpdateCrisMetricsInSolrDocService.java    | 34 ++++++++++++-------
 dspace/config/modules/metrics.cfg             |  6 +++-
 2 files changed, 27 insertions(+), 13 deletions(-)

diff --git a/dspace-api/src/main/java/org/dspace/metrics/UpdateCrisMetricsInSolrDocService.java b/dspace-api/src/main/java/org/dspace/metrics/UpdateCrisMetricsInSolrDocService.java
index d1a5788db9f8..3c6d1b4e639b 100644
--- a/dspace-api/src/main/java/org/dspace/metrics/UpdateCrisMetricsInSolrDocService.java
+++ b/dspace-api/src/main/java/org/dspace/metrics/UpdateCrisMetricsInSolrDocService.java
@@ -21,6 +21,7 @@
 import org.dspace.discovery.IndexingService;
 import org.dspace.discovery.SearchServiceException;
 import org.dspace.scripts.handler.DSpaceRunnableHandler;
+import org.dspace.services.ConfigurationService;
 import org.dspace.utils.DSpace;
 
 /**
@@ -30,6 +31,8 @@ public class UpdateCrisMetricsInSolrDocService {
 
     private static final Logger log = LogManager.getLogger(UpdateCrisMetricsInSolrDocService.class);
 
+    private ConfigurationService configurationService = new DSpace().getConfigurationService();
+
     private CrisMetricsService crisMetricsService = new DSpace().getServiceManager().getServiceByName(
             CrisMetricsServiceImpl.class.getName(), CrisMetricsServiceImpl.class);
 
@@ -42,21 +45,28 @@ public void performUpdate(Context context, DSpaceRunnableHandler handler, boolea
 
     public void performUpdate(Context context, DSpaceRunnableHandler handler, boolean optimize, UUID resourceUuid) {
         try {
-            List<CrisMetrics> metrics = resourceUuid == null
-                    ? crisMetricsService.findAllLast(context,-1,-1)
-                    : crisMetricsService.findLastMetricsByResourceId(context, resourceUuid, -1, -1);
+            int offset = 0;
+            int limit = configurationService.getIntProperty("metrics.indexer.page", 1000);
             handler.logInfo("Metric update start");
-            for (CrisMetrics metric : metrics) {
-                try {
-                    crisIndexingService.updateMetrics(context, metric);
-                } catch (RemoteSolrException rse) {
-                    if (StringUtils.containsIgnoreCase(rse.getMessage(), "Did not find child ID Item-")) {
-                        log.error(rse.getMessage());
-                    } else {
-                        throw rse;
+            List<CrisMetrics> metrics;
+            while (!(metrics = (resourceUuid == null
+                            ? crisMetricsService.findAllLast(context, limit, offset)
+                            : crisMetricsService.findLastMetricsByResourceId(context, resourceUuid, limit, offset)
+                            )).isEmpty()) {
+                for (CrisMetrics metric : metrics) {
+                    try {
+                        crisIndexingService.updateMetrics(context, metric);
+                    } catch (RemoteSolrException rse) {
+                        if (StringUtils.containsIgnoreCase(rse.getMessage(), "Did not find child ID Item-")) {
+                            log.error(rse.getMessage());
+                        } else {
+                            throw rse;
+                        }
                     }
                 }
+                offset += limit;
             }
+
             handler.logInfo("Metric update end");
             if (optimize) {
                 handler.logInfo("Starting solr optimization");
@@ -68,4 +78,4 @@ public void performUpdate(Context context, DSpaceRunnableHandler handler, boolea
             throw new RuntimeException(e.getMessage(), e);
         }
     }
-}
\ No newline at end of file
+}
diff --git a/dspace/config/modules/metrics.cfg b/dspace/config/modules/metrics.cfg
index f93df199aaa5..2d34353a61f8 100644
--- a/dspace/config/modules/metrics.cfg
+++ b/dspace/config/modules/metrics.cfg
@@ -25,6 +25,10 @@ metrics.scopus.person.instToken = ${scopus.instToken}
 # The default limit for the items to be updated by the update-metrics script, used if no limit is provided as parameter
 metrics.update-metrics-script.limit = 1750
 
+# The page size of CrisMetrics rows to process when updating the solr index
+# Default: 1000
+metrics.indexer.page = 1000
+
 #---------------------------------------------------------------#
 # Configure altmetric.com badges.                               #
 # See http://api.altmetric.com/embeds.html                      #
@@ -131,4 +135,4 @@ plumx.list-data-hide-mentions = false
 plumx.list-data-hide-socialmedia = false
 plumx.list-data-hide-citations = false
 plumx.list-data-pass-hidden-categories = false
-plumx.list-data-detail-same-page = false
\ No newline at end of file
+plumx.list-data-detail-same-page = false