feat: Add thumbnail deletion and cache busting for attachments

Author: jeanvier

src/Filesystem/Profile.php

@@ -170,6 +170,87 @@ public function delete($file, $force = false)
     if(($force || $this->getConfig('delete'))) $this->filesystem()->delete($file);
   }
 
+  /**
+   * Delete all thumbnails for a given file path.
+   *
+   * @param string $filePath The original file path (e.g., "images/photo.jpg")
+   * @return array List of deleted thumbnail paths
+   */
+  public function deleteThumbnails(string $filePath): array
+  {
+    $thumbProfileName = $this->getConfig('thumbnails');
+    if (empty($thumbProfileName) || $thumbProfileName === false) {
+      return [];
+    }
+
+    $thumbProfile = $this->thumbProfile();
+    $deletedPaths = [];
+    $profileDir = $this->name;
+
+    try {
+      $contents = $thumbProfile->listContents($profileDir, true);
+
+      foreach ($contents as $item) {
+        if ($item['type'] !== 'file') {
+          continue;
+        }
+
+        if ($this->matchesThumbnailPath($item['path'], $filePath, $profileDir)) {
+          try {
+            $thumbProfile->delete($item['path'], true);
+            $deletedPaths[] = $item['path'];
+          } catch (\Exception $e) {
+            // Continue with other deletions
+          }
+        }
+      }
+    } catch (\Exception $e) {
+      // listContents might fail on some adapters (e.g., External)
+    }
+
+    return $deletedPaths;
+  }
+
+  /**
+   * Check if a thumbnail path corresponds to the given original file path.
+   *
+   * @param string $thumbnailPath Full thumbnail path
+   * @param string $originalPath Original file path
+   * @param string $profileName Profile name
+   * @return bool
+   */
+  protected function matchesThumbnailPath(string $thumbnailPath, string $originalPath, string $profileName): bool
+  {
+    $thumbnailPath = str_replace(['/', '\\'], DS, $thumbnailPath);
+    $originalPath = str_replace(['/', '\\'], DS, $originalPath);
+
+    if (strpos($thumbnailPath, $profileName . DS) !== 0) {
+      return false;
+    }
+
+    // Direct suffix match
+    if (substr($thumbnailPath, -strlen($originalPath)) === $originalPath) {
+      return true;
+    }
+
+    // WebP conversion match
+    $thumbExt = strtolower(pathinfo($thumbnailPath, PATHINFO_EXTENSION));
+    $origExt = strtolower(pathinfo($originalPath, PATHINFO_EXTENSION));
+
+    if ($thumbExt === 'webp' && in_array($origExt, ['jpg', 'jpeg', 'png'])) {
+      $originalWithoutExt = pathinfo($originalPath, PATHINFO_DIRNAME) . DS .
+                            pathinfo($originalPath, PATHINFO_FILENAME);
+      $thumbWithoutExt = pathinfo($thumbnailPath, PATHINFO_DIRNAME) . DS .
+                         pathinfo($thumbnailPath, PATHINFO_FILENAME);
+
+      if (substr($thumbWithoutExt, -strlen($originalWithoutExt)) === $originalWithoutExt) {
+        return true;
+      }
+    }
+
+    return false;
+  }
+
   public function readAndDelete($path)
   {
     return $this->filesystem()->readAndDelete($path);

src/ORM/Behavior/FlyBehavior.php

@@ -133,6 +133,7 @@ public function beforeSave(Event $event, EntityInterface $entity, ArrayObject $o
       if(!empty($orginalValues[$field]))
       {
         $oldProfile = ProfileRegistry::retrieve(empty($orginalValues['profile'])? $conf['profile']: $orginalValues['profile']);
+        $oldProfile->deleteThumbnails($orginalValues[$field]);
         $oldProfile->delete($orginalValues[$field]);
         $afterReplace = $oldProfile->afterReplace;
       }
@@ -177,7 +178,11 @@ public function afterDelete(Event $event, EntityInterface $entity, ArrayObject $
   {
     $settings = $this->getConfig();
     $field = $settings['file_field'];
-    if(!empty($entity->get($field))) ProfileRegistry::retrieve($entity->get('profile'))->delete($entity->get($field));
+    if(!empty($entity->get($field))) {
+      $profile = ProfileRegistry::retrieve($entity->get('profile'));
+      $profile->deleteThumbnails($entity->get($field));
+      $profile->delete($entity->get($field));
+    }
   }
 
 }

src/View/Helper/AttachmentHelper.php

@@ -220,6 +220,14 @@ public function thumbSrc($params)
     foreach($dims as $key => $value) if (!empty($params[$key])) $url .= $value.$params[$key];
     if (!empty($params['cropratio'])) $url .= 'c'.str_replace(':','-',$params['cropratio']);
     $url = $url.'/'.$params['image'];
-    return ProfileRegistry::retrieve($profile)->thumbProfile()->getUrl($url);
+    $fullUrl = ProfileRegistry::retrieve($profile)->thumbProfile()->getUrl($url);
+
+    // Add version query param for cache busting (use modified timestamp or md5)
+    if (!empty($params['version'])) {
+      $separator = strpos($fullUrl, '?') !== false ? '&' : '?';
+      $fullUrl .= $separator . 'v=' . $params['version'];
+    }
+
+    return $fullUrl;
   }
 }