Skip to content

Handle empty environment overrides in vendor worker #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
1kuna wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Handle empty environment overrides in vendor worker #4

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 21 additions & 2 deletions trademl/workers/vendor_worker.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,25 @@ def _normalize_vendor(v: str) -> str:
return m


def _env_int(name: str, default: int = 0) -> int:
"""Read an integer environment variable safely."""

raw = os.getenv(name)
if raw is None:
return default
try:
raw = raw.strip()
except AttributeError:
# Non-string values (rare) are ignored and defaulted
return default
if raw == "":
return default
try:
return int(raw)
except ValueError:
return default


def _tasks_for_vendor_all(edge, vendor: str) -> List[str]:
# Mirror mapping logic from VendorSupervisor
mapping = {
Expand Down Expand Up @@ -98,8 +117,8 @@ def main():

parser = argparse.ArgumentParser(description="Per-vendor worker")
parser.add_argument("--vendor", default=os.getenv("VENDOR"), required=False)
parser.add_argument("--concurrency", type=int, default=int(os.getenv("CONCURRENCY", "0")))
parser.add_argument("--rpm", type=int, default=int(os.getenv("RPM_LIMIT", "0")))
parser.add_argument("--concurrency", type=int, default=_env_int("CONCURRENCY", 0))
parser.add_argument("--rpm", type=int, default=_env_int("RPM_LIMIT", 0))
parser.add_argument("--budget", type=int, default=os.getenv("BUDGET") or 0)
parser.add_argument("--config", default=os.getenv("EDGE_CONFIG", "configs/edge.yml"))
parser.add_argument("--tasks", default=os.getenv("TASKS", ""))
Expand Down