QuestionPool questions should be soft deleted

[cmatheny]

Currently deleting a question from the question pool table will cascade and delete all question evaluations referencing that question. The delete endpoint should soft delete questions by setting a field is_deleted to true, so existing evaluations are not affected but the question no longer shows up in searches. This will also require filtering search results for questions to ignore entries with is_deleted = true.

This may also apply to some other tables.

[tjkemper]

I agree for soft deletes because we will want to run reports.

Suggestions for other domains?

[cmatheny]

I think it is important for subject as well for the same reason. For other domains it's more optional. There won't be any side effects of hard-deleting an evaluation since only the question evals and comments depend on it, not the trainee or batch. Deleting a trainee or a batch would cascade delete all evaluations of that person/batch, but that also makes sense. I think it would just be a question of whether we want to permanently delete trainees/ batches/ evals or just hide them.

[eeolivas]

Soft delete all domains.

[tjkemper]

I agree with @eeolivas.

Soon we'll have security and every request will have to have a JWT. We could provide a hard delete option for higher privileged requests.

[eeolivas]

Are we still looking at being able to hard delete on higher-level requests from the API? Re-worked Person domain for soft CRUD- which means all hard-deletes would have to be done from the DB itself.

I may wait for security to be merged, so I can allow hard-deletes from the API - if that is how we want to go about it. Your call @tjkemper & @cmatheny .

[tjkemper]

I think it'd be okay to work on both soft and hard delete functionality before security is finalized.

If we clearly separate the endpoints, it should be straightforward to further secure the hard delete endpoints. For example, keeping the hard delete endpoints in their own controller.