-
Notifications
You must be signed in to change notification settings - Fork 122
Open
Labels
agglayerPRs or issues related to AggLayer bridging integrationPRs or issues related to AggLayer bridging integration
Description
To follow the other convention:
/// SMT node representation (32-byte Keccak256 hash)
pub type SmtNode = Keccak256Output;
/// Exit root representation (32-byte Keccak256 hash)
pub type ExitRoot = Keccak256Output;We should:
- Create the aliases for the leaf value and CGI chain hash.
- Add a
Keccak256Output::from_hexconstructor. - Move the
Keccak256Outputdefinition fromclaim_note.rsintoutils.rs.ExitRootandSmtNodealiases can stay inclaim_note.rs.
GlobalIndex struct duplicates a lot of the functionality of Keccak256Output, so we should rework the GlobalIndex struct into a trait which will extend Keccak256Output with the extra methods. These extended methods seem to be anyway used only for testing, so this new trait could have a cfg(test) attribute.
Originally posted by @mmagician in #2516 (comment)
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
agglayerPRs or issues related to AggLayer bridging integrationPRs or issues related to AggLayer bridging integration