diff --git a/CHANGELOG.md b/CHANGELOG.md index 496312b0cd..7ba3c07b92 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -34,6 +34,7 @@ - Removed `chain_tip` requirement from mempool subscription request ([#1771](https://github.com/0xMiden/node/pull/1771)). - Moved bootstrap procedure to `miden-node validator bootstrap` command ([#1764](https://github.com/0xMiden/node/pull/1764)). - NTX Builder now deactivates network accounts which crash repeatedly (configurable via `--ntx-builder.max-account-crashes`, default 10) ([#1712](https://github.com/0xMiden/miden-node/pull/1712)). +- Removed gRPC reflection v1-alpha support ([#1795](https://github.com/0xMiden/node/pull/1795)). ### Fixes diff --git a/crates/block-producer/src/server/mod.rs b/crates/block-producer/src/server/mod.rs index 61fad0181f..7392a15412 100644 --- a/crates/block-producer/src/server/mod.rs +++ b/crates/block-producer/src/server/mod.rs @@ -250,15 +250,6 @@ impl BlockProducerRpcServer { .build_v1() .context("failed to build reflection service")?; - // This is currently required for postman to work properly because - // it doesn't support the new version yet. - // - // See: . - let reflection_service_alpha = tonic_reflection::server::Builder::configure() - .register_file_descriptor_set(block_producer_api_descriptor()) - .build_v1alpha() - .context("failed to build reflection service")?; - // Build the gRPC server with the API service and trace layer. tonic::transport::Server::builder() @@ -268,7 +259,6 @@ impl BlockProducerRpcServer { .layer(TraceLayer::new_for_grpc().make_span_with(grpc_trace_fn)) .add_service(api_server::ApiServer::new(self)) .add_service(reflection_service) - .add_service(reflection_service_alpha) .serve_with_incoming(TcpListenerStream::new(listener)) .await .context("failed to serve block producer API") diff --git a/crates/rpc/src/server/mod.rs b/crates/rpc/src/server/mod.rs index 63de3f04ad..053398dc8c 100644 --- a/crates/rpc/src/server/mod.rs +++ b/crates/rpc/src/server/mod.rs @@ -60,15 +60,6 @@ impl Rpc { .build_v1() .context("failed to build reflection service")?; - // This is currently required for postman to work properly because - // it doesn't support the new version yet. - // - // See: . - let reflection_service_alpha = server::Builder::configure() - .register_file_descriptor_set(rpc_api_descriptor()) - .build_v1alpha() - .context("failed to build reflection service")?; - info!(target: COMPONENT, endpoint=?self.listener, store=%self.store_url, block_producer=?self.block_producer_url, "Server initialized"); let rpc_version = env!("CARGO_PKG_VERSION"); @@ -99,7 +90,6 @@ impl Rpc { .add_service(api_service) // Enables gRPC reflection service. .add_service(reflection_service) - .add_service(reflection_service_alpha) .serve_with_incoming(TcpListenerStream::new(self.listener)) .await .context("failed to serve RPC API") diff --git a/crates/store/src/server/mod.rs b/crates/store/src/server/mod.rs index d1b218be3f..8e9e46118b 100644 --- a/crates/store/src/server/mod.rs +++ b/crates/store/src/server/mod.rs @@ -123,17 +123,6 @@ impl Store { .build_v1() .context("failed to build reflection service")?; - // This is currently required for postman to work properly because - // it doesn't support the new version yet. - // - // See: . - let reflection_service_alpha = tonic_reflection::server::Builder::configure() - .register_file_descriptor_set(store_rpc_api_descriptor()) - .register_file_descriptor_set(store_ntx_builder_api_descriptor()) - .register_file_descriptor_set(store_block_producer_api_descriptor()) - .build_v1alpha() - .context("failed to build reflection service")?; - info!(target: COMPONENT, "Database loaded"); let mut join_set = JoinSet::new(); @@ -159,7 +148,6 @@ impl Store { .layer(TraceLayer::new_for_grpc().make_span_with(grpc_trace_fn)) .add_service(rpc_service) .add_service(reflection_service.clone()) - .add_service(reflection_service_alpha.clone()) .serve_with_incoming(TcpListenerStream::new(self.rpc_listener)), ); @@ -170,7 +158,6 @@ impl Store { .layer(TraceLayer::new_for_grpc().make_span_with(grpc_trace_fn)) .add_service(ntx_builder_service) .add_service(reflection_service.clone()) - .add_service(reflection_service_alpha.clone()) .serve_with_incoming(TcpListenerStream::new(self.ntx_builder_listener)), ); @@ -182,7 +169,6 @@ impl Store { .layer(TraceLayer::new_for_grpc().make_span_with(grpc_trace_fn)) .add_service(block_producer_service) .add_service(reflection_service) - .add_service(reflection_service_alpha) .serve_with_incoming(TcpListenerStream::new(self.block_producer_listener)), ); diff --git a/crates/validator/src/server/mod.rs b/crates/validator/src/server/mod.rs index bd636bc95e..6bb79c614a 100644 --- a/crates/validator/src/server/mod.rs +++ b/crates/validator/src/server/mod.rs @@ -70,15 +70,6 @@ impl Validator { .build_v1() .context("failed to build reflection service")?; - // This is currently required for postman to work properly because - // it doesn't support the new version yet. - // - // See: . - let reflection_service_alpha = tonic_reflection::server::Builder::configure() - .register_file_descriptor_set(validator_api_descriptor()) - .build_v1alpha() - .context("failed to build reflection service")?; - // Build the gRPC server with the API service and trace layer. tonic::transport::Server::builder() .layer(CatchPanicLayer::custom(catch_panic_layer_fn)) @@ -86,7 +77,6 @@ impl Validator { .timeout(self.grpc_options.request_timeout) .add_service(api_server::ApiServer::new(ValidatorServer::new(self.signer, db))) .add_service(reflection_service) - .add_service(reflection_service_alpha) .serve_with_incoming(TcpListenerStream::new(listener)) .await .context("failed to serve validator API")