From 7216a2e06a5957fbea437bfa48d47513e377fcf8 Mon Sep 17 00:00:00 2001 From: SantiagoPittella Date: Fri, 13 Mar 2026 13:47:31 -0300 Subject: [PATCH] fix: remove middle step serialization for InputNoteCommitment --- crates/proto/src/domain/transaction.rs | 10 +--------- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/crates/proto/src/domain/transaction.rs b/crates/proto/src/domain/transaction.rs index ee7d24bf2..0da1a0576 100644 --- a/crates/proto/src/domain/transaction.rs +++ b/crates/proto/src/domain/transaction.rs @@ -1,7 +1,6 @@ use miden_protocol::Word; use miden_protocol::note::Nullifier; use miden_protocol::transaction::{InputNoteCommitment, TransactionId}; -use miden_protocol::utils::serde::{Deserializable, Serializable}; use crate::errors::{ConversionError, MissingFieldHelper}; use crate::generated as proto; @@ -85,13 +84,6 @@ impl TryFrom for InputNoteCommitment { let header: Option = value.header.map(TryInto::try_into).transpose()?; - // TODO: https://github.com/0xMiden/node/issues/1783 - // InputNoteCommitment has private fields, so we reconstruct it via - // serialization roundtrip using its Serializable/Deserializable impls. - let mut bytes = Vec::new(); - nullifier.write_into(&mut bytes); - header.write_into(&mut bytes); - InputNoteCommitment::read_from_bytes(&bytes) - .map_err(|err| ConversionError::deserialization_error("InputNoteCommitment", err)) + Ok(InputNoteCommitment::from_parts_unchecked(nullifier, header)) } }